Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

28 enforce consistency on missing value handling in featurespy #51

Merged
merged 4 commits into from
May 8, 2024
Merged

28 enforce consistency on missing value handling in featurespy #51

merged 4 commits into from
May 8, 2024

Conversation

SStock1
Copy link
Collaborator

@SStock1 SStock1 commented May 7, 2024 •
edited
Loading

fixes #28

Pull request to:

  • Set the default value for dates that cannot be parsed to an empty list for gen_dateofbirth_features
  • Treat null values and empty strings in the same way for gen_misc_features
  • Update the tutorial to show these changes in action
  • Update the test for empty string values

@SStock1 SStock1 linked an issue May 7, 2024 that may be closed by this pull request
Enforce consistency on missing-value handling in features.py #28
Closed
@SStock1 SStock1 requested a review from matweldon May 7, 2024 11:01
@matweldon matweldon merged commit e18df4c into main May 8, 2024
4 checks passed
@matweldon
Copy link
Collaborator

Looks good 👍

@matweldon matweldon deleted the 28-enforce-consistency-on-missing-value-handling-in-featurespy branch May 8, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matweldon matweldon Awaiting requested review from matweldon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enforce consistency on missing-value handling in features.py
2 participants
@SStock1 @matweldon